Repository navigation
refactor(ui): tables, extensions and settings sections on QueryaButton - #1423
Merged
ZhuchkaTriplesix merged 2 commits intoOct 11, 2026
Merged
Conversation
…ryaButton Table toolbars (PostgreSQL, MySQL, SQLite, generic), staging toolbar, cell popover inspector, extension toolbar / card / recovery banner, the workspace empty hero and the appearance / about / extensions preference sections move to QueryaButton at md (sm for dense rows). Loading spinners become the button's loading state, the compact undo is a QueryaButton.icon, and the readonly-save test looks for QueryaButton. Part of #1337.
ZhuchkaTriplesix
deleted the
issue/1337-tables-extensions-settings-querya-button
branch
October 11, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1337 / #1331 (closes neither). Continues #1420, #1421, #1422.
What
Shadcn button calls become
QueryaButtonin 14 files:table_view_staging.Toolbars and panels are
md; dense rows (ButtonSize.small,ButtonDensity.compact) aresm.Beyond the mechanical replacement
loadinginstead of a spinnerleadingplus label switch.QueryaButton.iconwith a tooltip.OutlineButton(child: Row(Icon, SizedBox, Text))becomes a labelled secondary button with an icon (10 buttons); the codemod learned this shape in this pass.Tests
sql_workspace_readonly_save_testfound Save Changes asPrimaryButtonand read itsonPressed; it now looks forQueryaButton(sameonPressed, same enabled / disabled expectations).Still shadcn
QueryaActionButton/QueryaActionMenuand the toolbars built on them (Execute (F5) finders ingeneric_sql_workspace_shortcuts_test,sql_workspace_execute_dirty_guard_test,extension_sql_workspace_test) are next: they need the action button itself swapped.Not run locally; CI is the check.